Feat/blocklist #269
Feat/blocklist #269
Conversation
| <div> | ||
| <div className="text-xs font-medium tracking-wide text-[var(--text-secondary)] uppercase"> | ||
| Address | ||
| export const ContactInfoModal: FC<ContactInfoModalProps> = ({ |
There was a problem hiding this comment.
What do you think on placing the block button here instead?
There was a problem hiding this comment.
Blocking people doesn't seem too frequent, unless in broadcast and that has its own modal anyway.
What are you concerns?
There was a problem hiding this comment.
My only concern would be people not finding the option (dropdown + modal + dropdown)
I see people still having trouble to discover you have the ability to rename your contacts. But I'm fine with proposed changes, what just gathering your thoughts
There was a problem hiding this comment.
I have pushed changes with this. it does feel better. The modal warns people about whats going to happen, so I feel ok with the primary position.
Deleting wallet history deletes a blocked info too.
Also added import export ability.
- all blocks are now block and delete - lift method to store
HocusLocusTee
force-pushed
the
feat/blocklist
branch
from
43e2dc3 to
a62e94f
Compare
- post rebase cleanup - delete blocked-store for tenant ID - add import export for blocked addresses - bring settings modal into modal system
HocusLocusTee
force-pushed
the
feat/blocklist
branch
from
a62e94f to
38b9570
Compare
what?
initial 'block a contact' feature
adds:
ability to block from broadcasts or directs contact info pane
ability to see blocked addresses and a broadcast vis option in settings
stores the blocked address in db (also has the capacity for a 'reason') - note: my initial version included a reason field and allowed users to block an address straight from the settings, but I removed this as it was a little complicated handling the visibility states etc. So atm, we have no UI to add a reason and no way to block a contact unless its on their contact card.
blocking will delete any in db contact or messages. BUT in bcasts you will either still see a "Blocked Contact" message or no message (depending on your settings)
also adds
kasia-generalas a default initial channel. users can block now so this seems reasonable?